Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: Avoid deepcopy in Series arithmetic operations #4705

Closed
jbrockmendel opened this issue Jul 22, 2022 · 3 comments · Fixed by #4689
Closed

PERF: Avoid deepcopy in Series arithmetic operations #4705

jbrockmendel opened this issue Jul 22, 2022 · 3 comments · Fixed by #4689

Comments

@jbrockmendel
Copy link
Collaborator

xref #4689

In cases such as df[0] - df[1], we have df[0].index._id is df[1].index._id, which means the .equals check in the alignment step is cheep. Making a deep copy resets the two _id objects, making the alignment much more expensive.

@pyrito
Copy link
Collaborator

pyrito commented Jul 22, 2022

Thanks for opening the issue @jbrockmendel

jbrockmendel added a commit to jbrockmendel/modin that referenced this issue Jul 25, 2022
Signed-off-by: Brock Mendel <jbrockmendel@gmail.com>
YarShev pushed a commit that referenced this issue Jul 26, 2022
…jects with shared `.index` (#4689)

Signed-off-by: Brock Mendel <jbrockmendel@gmail.com>
@jbrockmendel
Copy link
Collaborator Author

closed by #4689?

@mvashishtha
Copy link
Collaborator

@jbrockmendel yes. On your future PRs please be sure fill out the PR template. The template includes a portion for the issue like Resolves #. If you put the issue number there, GitHub will close the issue automatically once the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants