-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: Avoid deepcopy in Series arithmetic operations #4705
Comments
Thanks for opening the issue @jbrockmendel |
jbrockmendel
added a commit
to jbrockmendel/modin
that referenced
this issue
Jul 25, 2022
Signed-off-by: Brock Mendel <jbrockmendel@gmail.com>
YarShev
pushed a commit
that referenced
this issue
Jul 26, 2022
closed by #4689? |
@jbrockmendel yes. On your future PRs please be sure fill out the PR template. The template includes a portion for the issue like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
xref #4689
In cases such as
df[0] - df[1]
, we havedf[0].index._id is df[1].index._id
, which means the.equals
check in the alignment step is cheep. Making a deep copy resets the two_id
objects, making the alignment much more expensive.The text was updated successfully, but these errors were encountered: