Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Series doesnt work correctly with sparse` at MODIN_STORAGE_FORMAT=omnisci #3823

Closed
Rubtsowa opened this issue Dec 9, 2021 · 1 comment · Fixed by #5377
Closed

Series doesnt work correctly with sparse` at MODIN_STORAGE_FORMAT=omnisci #3823

Rubtsowa opened this issue Dec 9, 2021 · 1 comment · Fixed by #5377
Labels
bug 🦗 Something isn't working HDK Related to HDK (OmniSci successor) engine or backend P2 Minor bugs or low-priority feature requests pandas concordance 🐼 Functionality that does not match pandas

Comments

@Rubtsowa
Copy link
Contributor

Rubtsowa commented Dec 9, 2021

When I run at MODIN_STORAGE_FORMAT=omnisci:

import numpy as np
import pandas
import modin.pandas as pd
pd.Series(pandas.arrays.SparseArray(np.array([3, 1, 2, 3, 4, np.nan])))

I have error:

TypeError: Sparse pandas data (column F___reduced__) not supported.
@Rubtsowa Rubtsowa added bug 🦗 Something isn't working HDK Related to HDK (OmniSci successor) engine or backend labels Dec 9, 2021
@Rubtsowa Rubtsowa mentioned this issue Dec 9, 2021
Closed
@Rubtsowa Rubtsowa changed the title Series not correct work with sparse at MODIN_STORAGE_FORMAT=omnisci Series is not working correctly with sparse at MODIN_STORAGE_FORMAT=omnisci Jan 14, 2022
@Rubtsowa Rubtsowa changed the title Series is not working correctly with sparse at MODIN_STORAGE_FORMAT=omnisci Series doesnt work correctly with sparse` at MODIN_STORAGE_FORMAT=omnisci Jan 17, 2022
@vnlitvinov
Copy link
Collaborator

@modin-project/modin-omnisci could someone please check if this still happens?

@devin-petersohn do we still want to support sparse data?..

@vnlitvinov vnlitvinov added pandas concordance 🐼 Functionality that does not match pandas P2 Minor bugs or low-priority feature requests labels Aug 26, 2022
AndreyPavlenko added a commit to AndreyPavlenko/modin that referenced this issue Dec 7, 2022
@AndreyPavlenko
FIX-modin-project#3823: Fixed TypeError when creating Series from Spa…
0522fa3 
…rseArray

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
@AndreyPavlenko AndreyPavlenko mentioned this issue Dec 7, 2022
Merged
7 tasks
YarShev pushed a commit that referenced this issue Dec 8, 2022
@AndreyPavlenko
FIX-#3823: Fix TypeError when creating Series from SparseArray (#5377)
4f62964 
Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🦗 Something isn't working HDK Related to HDK (OmniSci successor) engine or backend P2 Minor bugs or low-priority feature requests pandas concordance 🐼 Functionality that does not match pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX-#3823: Fix TypeError when creating Series from SparseArray AndreyPavlenko/modin
2 participants
@Rubtsowa @vnlitvinov