Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a constrain_crf option to the SequenceLabelingModel #22

Closed

Conversation

eduagarcia
Copy link

Fixes #21 .

Changes proposed in this pull request:

  • Adds an option called "constrain_crf" to the SequenceLabelingModel class, if use_crf and constrain_crf are both True then it substitutes the CRF module with the CRFwithConstraints module that implements constrains for BIO and BIOES valid tag decoding.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the create a branch and work section CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@eduagarcia eduagarcia changed the title Feature/constrain crf slm Add a constrain_crf option to the SequenceLabelingModel May 17, 2023
@eduagarcia eduagarcia closed this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add a constrain_crf option to the SequenceLabelingModel
1 participant