Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): failed test icon color #4946

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

kleisauke
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Due to the wrong variable being referenced in #mocha .test.fail::before, the failed test icon () is currently incorrectly colored as #00d6b2 instead of #cc0000 (light schema) or #ff4444 (dark schema). See for example the screenshot posted in comment #4896 (comment).

Alternate Designs

n/a - this is clearly a bug fix.

Why should this be in core?

n/a - this is clearly a bug fix.

Benefits

Users may now notice test errors more easily, which makes developers, especially the UX/UI ones, happier.

Possible Drawbacks

n/a - this is clearly a bug fix.

Applicable issues

Regressed since #4896, mentioned 15 days ago (as a review comment) in #4896 (comment), but since there was no response to that, I decided to open this PR.

The failed test icon is currently incorrectly colored as `#00d6b2`
instead of `#cc0000` (light schema) or `#ff4444` (dark schema).

To fix this, ensure that the correct var is referenced.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 13, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kleisauke / name: Kleis Auke Wolthuizen (6f88dd3)

@juergba juergba added area: browser browser-specific area: reporters involving a specific reporter semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Nov 14, 2022
@juergba juergba added this to the next milestone Nov 14, 2022
@juergba juergba added the run-browser-test run browser tests on forked PR if code is safe label Nov 14, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.326% when pulling 6f88dd3 on kleisauke:fix-failed-test-icon-color into 3cc9cac on mochajs:master.

@github-actions github-actions bot removed the run-browser-test run browser tests on forked PR if code is safe label Nov 14, 2022
Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kleisauke thank you

@juergba juergba merged commit b0a0fb8 into mochajs:master Nov 14, 2022
@kleisauke kleisauke deleted the fix-failed-test-icon-color branch November 14, 2022 19:28
This was referenced Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: browser browser-specific area: reporters involving a specific reporter semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants