-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
probot should lock old issues #3377
Comments
+1 |
Two months seems a frightfully short period given how long it takes things to "complete" here. I tend to use closed issues in a more StackOverflow-style myself, noting some additional piece of the puzzle maybe related but maybe unworthy of YA issue. Having to look through multiple issues on exact same topic trying to find that one thing I read earlier is exhausting. |
@plroebuck It's a tradeoff. I assume you've read the blog post and understand why this would be helpful for maintainers? 60 days seems a reasonable amount of time--to me--to go between when an issue is closed with a PR fix and when that fix is released. I would increase this to 90 in the case that someone finds a problem with the fix well after the release (in which case, commenting on the PR might be a better idea anyway). Does that sound better? Also... I don't understand this:
We're talking about closed issues; we won't be automatically locking any open ones... until after they are closed for being stale, of course. |
+1 Notifications on closed issues, as dan mentioned, are usually not useful. Users can always open new ones if they feel the locked/closed issues needs fresh attention. I'd even argue with pushing it back to 45 days! But 60 sounds fair as well. In an ideal scenario, we'd have the bot comment something among these lines when locking the issue
|
Totally agreed. 60 days is good for me. To clear, when there is an issue which is inactive, the probot label it as |
@outsideris closed issues are locked after 60 days so no one can comment on them or react to existing comments. |
You're right for a case of closed issues. |
@Bamieh The issue with the comment as suggested:
is that maintainers will receive a notification for the comment.. |
@boneskull hahaha, then the bot would be causing the same issue it was created to solve. |
@Bamieh 😉 exactly, but it'd be even worse, because it'd happen on every issue! |
If we still agree with this, I will try to integrate the probot to lock closed comments. I feel that maintainers are suffering from comments on closed issues. |
We ended up going against this in #5029. |
Inactive, closed issues should be automatically marked as "locked"; we would prefer new issues are created instead.
Henry Zhu's blog has a post about this.
I'd like the following settings, but this is open to debate:
cc @mochajs/core
The text was updated successfully, but these errors were encountered: