Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverse ROC #79

Closed
gustavlindved opened this issue Aug 11, 2021 · 2 comments
Closed

Inverse ROC #79

gustavlindved opened this issue Aug 11, 2021 · 2 comments

Comments

@gustavlindved
Copy link

Thanks for a really great and useful package!

It seems that something might have changed in the way that the ROC curve is plotted using the autoplot() function - it's currently inverse of what you would expect whenever I use autoplot(rr, type = "roc").

If you take a look at the mlr3 book it also seems that it is happening here https://mlr3book.mlr-org.com/benchmarking.html

@mllg mllg transferred this issue from mlr-org/mlr3 Aug 11, 2021
@mllg mllg closed this as completed in 8200e6f Aug 11, 2021
@mllg
Copy link
Sponsor Member

mllg commented Aug 11, 2021

This is actually a bug in the visualization. ResampleResult and BenchmarkResult were affected, and AFAICT, the problem only occurs iff the order of labels is not alphabetical. Now fixed and tested, the new version will hit CRAN tomorrow.

Thanks for reporting.

@gustavlindved
Copy link
Author

Thank you for fixing this so quickly! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants