Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressBar() does not work with L_BFGS #361

Open
tonideleo opened this issue Feb 25, 2023 · 3 comments
Open

ProgressBar() does not work with L_BFGS #361

tonideleo opened this issue Feb 25, 2023 · 3 comments

Comments

@tonideleo
Copy link

Issue description

Following the example.cpp, I was playing around with some callbacks functions. For example, I realized if I use the Adam optimizer, the callback function ProgressBar() works without issues; however, it does not work with L_BFGS. In the documentation I did not find any exception use for this callback nor limitation in the section regarding the L_BFGS.

Your environment

  • version of ensmallen: 2.19.0
  • operating system: Windows 10
  • compiler: MS Visual Studio 2022 (ensmallen installed via vcpkg and cmake)
  • version of Armadillo: 11.4.4
  • any other environment information you think is relevant:

Steps to reproduce

In line 64 of the example, substitute the following:
opt.Optimize(lrf, theta, ens::ProgressBar());

Expected behavior

I was expecting to see the progress bar, which by the way it worked if I used a different optimizer.

Actual behavior

image

@conradsnicta
Copy link
Contributor

@zoq may have more insight here. It's possible that ens::ProgressBar() doesn't support L_BFGS

@zoq
Copy link
Member

zoq commented Feb 27, 2023

That is correct, ens::ProgressBar() doesn't support L_BFGS, but I don't see a reason why it couldn't. I'm opening a PR to add support.

@conradsnicta
Copy link
Contributor

@tonideleo it may take a while before progress bar supports L_BFGS. The ensmallen library is a volunteer driven project, so if you'd like to see the support earlier, you're welcome to contribute code 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants