Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in inference #922

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

vahluw
Copy link
Contributor

@vahluw vahluw commented Aug 16, 2024

…2D patches

Fixes #ISSUE_NUMBER

Proposed Changes

  • When using a 2D patch such as (2048, 2048), during validation the patch shape is (2048, 2048, 1). This triggers the else statement in forward_pass.py, causing an issue when trying to squeeze().

Checklist

  • [ x] CONTRIBUTING guide has been followed.
  • [ x] PR is based on the current GaNDLF master .
  • [ x] Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • [x ] If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@vahluw vahluw requested a review from a team as a code owner August 16, 2024 21:03
Copy link
Contributor

github-actions bot commented Aug 16, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@vahluw
Copy link
Contributor Author

vahluw commented Aug 17, 2024

recheck

Geeks-Sid
Geeks-Sid previously approved these changes Aug 18, 2024
Copy link
Collaborator

@Geeks-Sid Geeks-Sid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

GANDLF/compute/forward_pass.py Outdated Show resolved Hide resolved
@sarthakpati sarthakpati changed the title Fixed bug in compute/forward_pass.py line 359 that caused error with … Fixed bug in inference portion for 2d images Aug 19, 2024
@sarthakpati sarthakpati changed the title Fixed bug in inference portion for 2d images Fixed bug in inference Aug 19, 2024
@sarthakpati sarthakpati changed the title Fixed bug in inference Fixed bug in inference Aug 19, 2024
@sarthakpati sarthakpati merged commit e9d92ae into mlcommons:master Aug 19, 2024
20 of 22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants