Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS #867

Merged
merged 3 commits into from
May 31, 2024
Merged

Create CODEOWNERS #867

merged 3 commits into from
May 31, 2024

Conversation

sarthakpati
Copy link
Collaborator

Fixes #N.A.

Proposed Changes

  • create a CODEOWNERS file to triage the review process

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@sarthakpati sarthakpati requested a review from a team May 13, 2024 04:15
Copy link
Contributor

github-actions bot commented May 13, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.11%. Comparing base (92a6c42) to head (120b699).

Current head 120b699 differs from pull request most recent head 9c5ae77

Please upload reports for the commit 9c5ae77 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
+ Coverage   95.10%   95.11%   +0.01%     
==========================================
  Files         122      122              
  Lines        8309     8326      +17     
==========================================
+ Hits         7902     7919      +17     
  Misses        407      407              
Flag Coverage Δ
unittests 95.11% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarthakpati sarthakpati merged commit 91d9004 into master May 31, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
@sarthakpati sarthakpati deleted the sarthakpati-patch-1 branch May 31, 2024 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants