-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schedulers monai #807
Add schedulers monai #807
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
==========================================
- Coverage 95.05% 95.02% -0.03%
==========================================
Files 119 120 +1
Lines 8288 8267 -21
==========================================
- Hits 7878 7856 -22
- Misses 410 411 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting minor changes.
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
Co-authored-by: Sarthak Pati <patis@iu.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #805
Proposed Changes
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].