-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional PSNR evaluations for the normalized synthesis case #703
Conversation
As we normalize the data to [0;1], we have top-down knowledge now about the data range. For this knowledge I added two cases/columns of PSNR evaluations.
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Thanks! 👍🏽 Can you put the comment before the line that it represents for readability? Basically, instead of this: overall_stats_dict[current_subject_id]["psnr"] = peak_signal_noise_ratio( #torchmetrics PSNR using "max"
gt_image_infill, output_infill
).item() You put this: #torchmetrics PSNR using "max"
overall_stats_dict[current_subject_id]["psnr"] = peak_signal_noise_ratio(gt_image_infill, output_infill).item() And then run |
Codecov Report
@@ Coverage Diff @@
## master #703 +/- ##
==========================================
- Coverage 94.69% 94.68% -0.02%
==========================================
Files 117 117
Lines 8225 8228 +3
==========================================
+ Hits 7789 7791 +2
- Misses 436 437 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As we normalize the data to [0;1], we have top-down knowledge now about the data range. For this knowledge I added two cases/columns of PSNR evaluations.
Proposed Changes
This PR should be very minor, but relevant for the in-painting-chellange.
Checklist
CONTRIBUTING
guide.pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].