Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a temporary fix for protobuf #702

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Added a temporary fix for protobuf #702

merged 3 commits into from
Aug 2, 2023

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Aug 1, 2023

Fixes #N.A.

Proposed Changes

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@sarthakpati sarthakpati marked this pull request as draft August 1, 2023 21:05
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati changed the title checking a fix for openfl-CI Added a temporary fix for protobuf Aug 1, 2023
@sarthakpati sarthakpati requested review from Geeks-Sid and a team August 1, 2023 21:27
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #702 (f714ef0) into master (d1fc9e2) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   94.68%   94.69%   +0.01%     
==========================================
  Files         117      117              
  Lines        8200     8200              
==========================================
+ Hits         7764     7765       +1     
+ Misses        436      435       -1     
Flag Coverage Δ
unittests 94.69% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarthakpati sarthakpati marked this pull request as ready for review August 2, 2023 00:58
@sarthakpati sarthakpati merged commit 6579e15 into master Aug 2, 2023
18 checks passed
@Geeks-Sid Geeks-Sid deleted the openfl_ci_fix branch August 2, 2023 08:07
@Geeks-Sid Geeks-Sid restored the openfl_ci_fix branch August 2, 2023 08:07
@Geeks-Sid Geeks-Sid deleted the openfl_ci_fix branch August 2, 2023 08:07
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants