-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated install verification logic #520
Updated install verification logic #520
Conversation
gandlf_verifyInstall
by removing default copyright message
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
gandlf_verifyInstall
by removing default copyright messagegandlf_verifyInstall
…n-git-submodules-are-absent
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
- Coverage 93.62% 93.60% -0.02%
==========================================
Files 106 106
Lines 6726 6726
==========================================
- Hits 6297 6296 -1
- Misses 429 430 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gandlf_verifyInstall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
Fixes #519
Proposed Changes
python
directly, invokingsys.executable
for a less error-prone install solutionChecklist
CONTRIBUTING
guidepip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]