Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated install verification logic #520

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Nov 16, 2022

Fixes #519

Proposed Changes

  • removed default copyright message from being picked up, thus allowing the failure to get fixed
  • code black for collectStats
  • instead of invoking python directly, invoking sys.executable for a less error-prone install solution

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@sarthakpati sarthakpati changed the title fixed verify install Fixed gandlf_verifyInstall by removing default copyright message Nov 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati sarthakpati changed the title Fixed gandlf_verifyInstall by removing default copyright message Fixed gandlf_verifyInstall Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #520 (29f52b5) into master (8616128) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   93.62%   93.60%   -0.02%     
==========================================
  Files         106      106              
  Lines        6726     6726              
==========================================
- Hits         6297     6296       -1     
- Misses        429      430       +1     
Flag Coverage Δ
unittests 93.60% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...NDLF/data/preprocessing/template_matching/utils.py 95.34% <0.00%> (-2.33%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sarthakpati sarthakpati changed the title Fixed gandlf_verifyInstall Updated install verification logic Nov 16, 2022
Copy link
Collaborator

@AlexanderGetka-cbica AlexanderGetka-cbica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

@sarthakpati sarthakpati merged commit bb6d70a into mlcommons:master Nov 16, 2022
@sarthakpati sarthakpati deleted the 519-running-gandlf_verifyinstall-fails-when-git-submodules-are-absent branch November 16, 2022 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running gandlf_verifyInstall fails when git submodules are absent
2 participants