Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely excising VIPS from GaNDLF #480

Merged
merged 6 commits into from
Sep 1, 2022

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Sep 1, 2022

Fixes #479

Proposed Changes

  • vips --> opencv

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@sarthakpati sarthakpati marked this pull request as draft September 1, 2022 16:53
@sarthakpati sarthakpati changed the title Replacing VIPS with OpenCV Completely excising VIPS from GaNDLF Sep 1, 2022
@sarthakpati sarthakpati marked this pull request as ready for review September 1, 2022 17:20
@sarthakpati sarthakpati merged commit f4c4752 into mlcommons:master Sep 1, 2022
@sarthakpati sarthakpati deleted the 479_no_vips branch September 1, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vips installation is a pain and should be made optional, or use something else entirely
2 participants