-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added blending probability maps with original WSI #465
Added blending probability maps with original WSI #465
Conversation
…aNDLF into wsi_inference_blend
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
- Coverage 92.46% 92.42% -0.04%
==========================================
Files 105 105
Lines 6276 6287 +11
==========================================
+ Hits 5803 5811 +8
- Misses 473 476 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @sarthakpati, have you tested this with svs or tiffs that are of the size 1GB+ in their original format? |
@Geeks-Sid unfortunately I have not, and I do not have access to such data right now. If you or @ujjwalbaid0408 could test it, it would be great! |
Yes, I believe this would require such testing because saving png images with the blended heat map and figuring out a way to read them in a multi-tiff manner is not that trivial from my experience. I will test this by end of the week. Also, great work! |
Any update? @Geeks-Sid @ujjwalbaid0408 |
This works for tiff as I tested a slide for the given condition. LGTM! |
Cool, I fixed a codacy issue, so this should be ready to merge, unless @ujjwalbaid0408 has objections? |
@ujjwalbaid0408 and I have verified results from this using testing data for the TIL prediction project. This is good to merge. |
Fixes #464
Proposed Changes
blending_alpha
agni
that is pure red and black for easier visualizationChecklist
CONTRIBUTING
guidepip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]