Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved default step_size calculation #386

Merged
merged 8 commits into from
Mar 31, 2022

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Mar 31, 2022

Fixes #N.A.

Proposed Changes

  • default step_size updated to be learning_rate / 5.0 instead of len(training_data) / learning_rate

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (would not break existing functionality): please provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@dagshub
Copy link

dagshub bot commented Mar 31, 2022

@sarthakpati sarthakpati changed the title Improved default step size Improved default step_size calculation Mar 31, 2022
Geeks-Sid
Geeks-Sid previously approved these changes Mar 31, 2022
Geeks-Sid
Geeks-Sid previously approved these changes Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #386 (fb94164) into master (176f900) will decrease coverage by 0.01%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   91.73%   91.71%   -0.02%     
==========================================
  Files          94       94              
  Lines        5479     5482       +3     
==========================================
+ Hits         5026     5028       +2     
- Misses        453      454       +1     
Flag Coverage Δ
unittests 91.71% <95.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/compute/training_loop.py 83.95% <ø> (-0.14%) ⬇️
GANDLF/schedulers/__init__.py 100.00% <ø> (ø)
GANDLF/schedulers/wrap_torch.py 100.00% <ø> (ø)
testing/test_full.py 98.17% <94.11%> (-0.10%) ⬇️
GANDLF/parseConfig.py 75.43% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176f900...fb94164. Read the comment docs.

@sarthakpati sarthakpati merged commit be40937 into mlcommons:master Mar 31, 2022
@sarthakpati sarthakpati deleted the improved_default_step_size branch March 31, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants