-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved default step_size
calculation
#386
Merged
sarthakpati
merged 8 commits into
mlcommons:master
from
sarthakpati:improved_default_step_size
Mar 31, 2022
Merged
Improved default step_size
calculation
#386
sarthakpati
merged 8 commits into
mlcommons:master
from
sarthakpati:improved_default_step_size
Mar 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakpati
changed the title
Improved default step size
Improved default Mar 31, 2022
step_size
calculation
Geeks-Sid
previously approved these changes
Mar 31, 2022
…akpati/GaNDLF into improved_default_step_size
Geeks-Sid
previously approved these changes
Mar 31, 2022
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
- Coverage 91.73% 91.71% -0.02%
==========================================
Files 94 94
Lines 5479 5482 +3
==========================================
+ Hits 5026 5028 +2
- Misses 453 454 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Geeks-Sid
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N.A.
Proposed Changes
step_size
updated to belearning_rate / 5.0
instead oflen(training_data) / learning_rate
Checklist
CONTRIBUTING
guidepip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]