Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some checks for inference mode #358

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Mar 18, 2022

Fixes #N.A.

Proposed Changes

Checklist

  • I have read the CONTRIBUTING guide
  • My PR is based from the current GaNDLF master
  • Non-breaking change (would not break existing functionality): please provide as many details as possible for any breaking change
  • Function/class source code documentation added/updated
  • Code has been blacked for style consistency
  • If applicable, version information has been updated in GANDLF/version.py
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
  • Usage documentation has been updated, if appropriate
  • History has been updated, if appropriate
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

@sarthakpati
Copy link
Collaborator Author

Hey @AlexanderGetka-cbica,

The docker builds are failing for every PR. Is there any way we can get them to run for everything single PR?

@AlexanderGetka-cbica
Copy link
Collaborator

Hey @AlexanderGetka-cbica,

The docker builds are failing for every PR. Is there any way we can get them to run for everything single PR?

#359 Just put this in 😆

@sarthakpati
Copy link
Collaborator Author

Hey @AlexanderGetka-cbica,
The docker builds are failing for every PR. Is there any way we can get them to run for everything single PR?

#359 Just put this in 😆

Thanks, man.

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #358 (d70e9d5) into master (f6894fd) will increase coverage by 0.00%.
The diff coverage is 57.14%.

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   90.96%   90.97%           
=======================================
  Files          89       89           
  Lines        4828     4829    +1     
=======================================
+ Hits         4392     4393    +1     
  Misses        436      436           
Flag Coverage Δ
unittests 90.97% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/cli/main_run.py 65.78% <57.14%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611baa1...d70e9d5. Read the comment docs.

@sarthakpati sarthakpati merged commit 688833a into mlcommons:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants