-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfiles and Docker Hub CI #353
Add Dockerfiles and Docker Hub CI #353
Conversation
add initial Dockerfiles
fix CWD/WORKDIR
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 89 89
Lines 4828 4828
=======================================
Hits 4392 4392
Misses 436 436
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Thanks for the PR, @AlexanderGetka-cbica! Can you tell me how to fix the error in the builds? |
I added the secret variables: But I am still getting the same error. Am I missing something? |
Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
Let's merge and see what happens!! |
Proposed Changes
This workflow also can be run manually from any branch, taking a version tag as input, to publish under that tag on Docker Hub. It'll be appended to the platform, so inputting "v1" will yield cbica/gandlf:cuda102-v1, cbica/gandlf:cuda113-v1 ... you get the picture.
In order for this push to work, DOCKER_HUB_USER and DOCKER_HUB_TOKEN need to be present under Secrets in the GitHub repo settings. I recommend using a Docker Hub PAT (instructions here).
Note that even if you set the above, the authentication will fail for this PR, because PRs from forks can't access secrets ("username and password required"). But I've tested it separately on my repo and it should work.
Let me know if I need to change anything else.
Checklist
CONTRIBUTING
guide