Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfiles and Docker Hub CI #353

Merged
merged 53 commits into from
Mar 18, 2022

Conversation

AlexanderGetka-cbica
Copy link
Collaborator

@AlexanderGetka-cbica AlexanderGetka-cbica commented Mar 18, 2022

Proposed Changes

  • Add Dockerfiles corresponding to CUDA10.2, CUDA11.3, ROCm and CPU platforms.
  • Add a workflow that automatically builds Docker images from the above on push or PR targeting master, and publishes them to Docker Hub on push.

This workflow also can be run manually from any branch, taking a version tag as input, to publish under that tag on Docker Hub. It'll be appended to the platform, so inputting "v1" will yield cbica/gandlf:cuda102-v1, cbica/gandlf:cuda113-v1 ... you get the picture.

In order for this push to work, DOCKER_HUB_USER and DOCKER_HUB_TOKEN need to be present under Secrets in the GitHub repo settings. I recommend using a Docker Hub PAT (instructions here).

Note that even if you set the above, the authentication will fail for this PR, because PRs from forks can't access secrets ("username and password required"). But I've tested it separately on my repo and it should work.

Let me know if I need to change anything else.

Checklist

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #353 (53bbb85) into master (64d024a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files          89       89           
  Lines        4828     4828           
=======================================
  Hits         4392     4392           
  Misses        436      436           
Flag Coverage Δ
unittests 90.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d024a...53bbb85. Read the comment docs.

@sarthakpati
Copy link
Collaborator

Thanks for the PR, @AlexanderGetka-cbica! Can you tell me how to fix the error in the builds?

image

@sarthakpati sarthakpati self-requested a review March 18, 2022 00:46
@sarthakpati sarthakpati added the enhancement New feature or request label Mar 18, 2022
@sarthakpati
Copy link
Collaborator

sarthakpati commented Mar 18, 2022

Thanks for the PR, @AlexanderGetka-cbica! Can you tell me how to fix the error in the builds?

image

I added the secret variables:

image

But I am still getting the same error. Am I missing something?

Co-authored-by: Sarthak Pati <sarthak.pati@pennmedicine.upenn.edu>
@sarthakpati sarthakpati changed the base branch from master to docker_ci March 18, 2022 01:51
@sarthakpati
Copy link
Collaborator

Let's merge and see what happens!!

@sarthakpati sarthakpati merged commit 56ad7b2 into mlcommons:docker_ci Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants