Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to save training patches #263

Merged
merged 30 commits into from
Dec 27, 2021

Conversation

sarthakpati
Copy link
Collaborator

@sarthakpati sarthakpati commented Dec 26, 2021

Fixes #262

Proposed Changes

Checklist

@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #263 (5def3ee) into master (5a949da) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   87.23%   87.33%   +0.09%     
==========================================
  Files          80       80              
  Lines        4169     4194      +25     
==========================================
+ Hits         3637     3663      +26     
+ Misses        532      531       -1     
Flag Coverage Δ
unittests 87.33% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
GANDLF/parseConfig.py 74.72% <ø> (ø)
GANDLF/utils/__init__.py 100.00% <ø> (ø)
setup.py 0.00% <ø> (ø)
GANDLF/compute/training_loop.py 80.97% <100.00%> (+0.28%) ⬆️
GANDLF/utils/imaging.py 83.33% <100.00%> (+4.76%) ⬆️
GANDLF/utils/parameter_processing.py 100.00% <100.00%> (ø)
testing/test_full.py 99.00% <100.00%> (+<0.01%) ⬆️
GANDLF/utils/generic.py 82.50% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a949da...5def3ee. Read the comment docs.

@sarthakpati sarthakpati mentioned this pull request Dec 26, 2021
10 tasks
Geeks-Sid
Geeks-Sid previously approved these changes Dec 27, 2021
@Geeks-Sid
Copy link
Collaborator

Looks good to me.

@Geeks-Sid Geeks-Sid merged commit 0840868 into mlcommons:master Dec 27, 2021
@sarthakpati sarthakpati deleted the 262_training_patches_write branch December 27, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to write training images
2 participants