Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest failure without numba. #72

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

sebastic
Copy link

@sebastic sebastic commented Jan 7, 2023

The Debian package needs to be built without numba cause llvmlite is buggy.

@ml31415
Copy link
Owner

ml31415 commented Jan 9, 2023

Hello @sebastic I'd be fine merging that request. Nevertheless, I'd like to note that without the numba implementation, this package is not much more than some syntax candy around inbuilt numpy operations. So without numba available, I'm not sure if it would be worth packaging this package at all.

@sebastic
Copy link
Author

sebastic commented Jan 9, 2023

numpy-groupies is a dependency of flox which in turn is a dependency of sarsen, having these back in the upcoming stable release is more important. If/when numba/llvmlite get fixed during the next development cycle its use in numpy-groupies can be reinstated.

@ml31415 ml31415 merged commit 3ab5474 into ml31415:master Jan 9, 2023
@sebastic sebastic deleted the numba branch January 9, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants