Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 pop up when the folder name contains notebooks #63

Closed
allenzhao opened this issue Dec 24, 2020 · 2 comments
Closed

404 pop up when the folder name contains notebooks #63

allenzhao opened this issue Dec 24, 2020 · 2 comments
Labels
bug Something isn't working as expected in progress The issue is currently being resolved

Comments

@allenzhao
Copy link

Describe the bug:

When the folder name contains notebooks, seems this line of code will cause two unexpected popup, showing 404 as a result.

See image:
image

Console says js tried to load tooling/tools and tooling/storage/check after the baseURL was reconginized as the current full url, which caused the bug.
Expected behaviour:
Works fine without the popup.

Steps to reproduce the issue:

  1. Create a folder named notebooks
  2. Create a notebook
  3. Two popups shows errors

Technical details:

  • Workspace version :
  • Docker version :
  • Host Machine OS (Windows/Linux/Mac):
  • Command used to start the workspace :
  • Browser (Chrome/Firefox/Safari):

Possible Fix:
A better way of the regex?

Additional context:
I discovered this and thought it was related to #62 at first, and was somehow caused by the pydeck extension. Then later I found out that it was actually a different bug ;)

@allenzhao allenzhao added the bug Something isn't working as expected label Dec 24, 2020
@lukasmasuch lukasmasuch added the in progress The issue is currently being resolved label Dec 24, 2020
@lukasmasuch
Copy link
Contributor

@allenzhao Good catch, thanks! I already changed the regex a few days ago (fa0c539) :) But I will need to test if this fixes the mentioned problem.

@lukasmasuch
Copy link
Contributor

@allenzhao This issue should be fixed in the new release: https://github.com/ml-tooling/ml-workspace/tree/v0.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected in progress The issue is currently being resolved
Projects
None yet
Development

No branches or pull requests

2 participants