Group support for conv3d
#1262
Open
Group support for conv3d
#1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated acknowledgments
|
Looks good to me. Do you mind sharing the results of a benchmark to see how well the groups parameter works for 3D convs? Ideally we should get a nice speed up when using a large number of groups. |
Thanks, I'll add some benchmarks! |
|
@mlaves what's the status of this PR? Should we try and land it soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added group support to
conv3dforward pass (backward pass still missing, as forconv2d). I adaptedslow_conv_3D,explicit_gemm_conv_ND_cpu, andconv_3D_gputo supportgroups > 1and added tests.Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes