feat: add cross_product #1252
Merged
feat: add cross_product #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altaic
suggested changes
Jul 5, 2024
angeloskath
reviewed
Jul 6, 2024
There was a problem hiding this comment.
Thanks for the addition!
I would start by making sure that the API follows the corresponding numpy API https://numpy.org/devdocs/reference/generated/numpy.linalg.cross.html including the axis argument.
Regarding the implementation, I would look into split and concatenate.
|
@NripeshN are you planning to come back to this? |
|
@NripeshN are you planning to come back to this PR? |
altaic
reviewed
Aug 24, 2024
awni
force-pushed
the
cross_product
branch
2 times, most recently
from
844413f
to
0a28f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1244