-
Notifications
You must be signed in to change notification settings - Fork 562
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rewrite Row.__repr__ to eliminate Unicode error
The debug build of Python generates an assertion that the resulting string we created has the wrong type. I think the issue was that we had a 1-byte string but it was not marked as ASCII even though it had no values > 127. Therefore I don't think it was causing problems or any exploitable issues, but I'm not sure. I replaced the implementation with simply building a temporary tuple with the values and calling repr on them. (Perhaps I should consider storing the rows in a Tuple instead of a handcoded array?) I also closed some popen pipes in the setup.py to eliminate some errors when PYTHONDEVMODE=1.
- Loading branch information
1 parent
4829107
commit 615ebdd
Showing
2 changed files
with
13 additions
and
115 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters