Add __slots__ to AsyncLimiter
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjpieters
reviewed
Aug 8, 2022
There was a problem hiding this comment.
I love it. Yes, I'm well aware of the advantages of using __slots__!
I have only two reservations:
- with this change you no longer can create weak references to limiter instances. I don't think this is a big issue; we can always add
__weakref__to the slots listing if someone comes up with a compelling use-case in future. - can you please add a changelog entry for this? Create a
85.featurefile in thechangelog.ddirectory describing this change (format is restructuredtext).
mjpieters
requested changes
Aug 9, 2022
Co-authored-by: Martijn Pieters <github.com@zopatista.com>
|
Kudos, SonarCloud Quality Gate passed!
|
mjpieters
approved these changes
Aug 9, 2022
|
And, merged! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
__slots__reduces memory usage (important here since one can have many AsyncLimiter instances) and speeds up attribute access. See here to learn more