Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for dark mode on macOS #10044

Closed
mixxxbot opened this issue Aug 23, 2022 · 8 comments
Closed

add support for dark mode on macOS #10044

mixxxbot opened this issue Aug 23, 2022 · 8 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: foss-4
Date: 2020-07-12T11:38:43Z
Status: Fix Committed
Importance: Low
Launchpad Issue: lp1887280
Attachments: [mixxx dark mode macOS.png](https://bugs.launchpad.net/bugs/1887280/+attachment/5434846/+files/mixxx dark mode macOS.png)


Currently window title bar and settings are in light mode only.

Would be great if Mixxx adapted the macOS system setting to follow user preferences for dark / light mode and when users are using dark mode support showing the window title bar and preferences in dark mode.

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2020-07-12T11:52:06Z


I think we have to update the macOS SDK used in the build environment:
https://doc.qt.io/qt-5/macos.html#opting-out-of-macos-behavior-changes

So this is blocked on #1974

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-07-13T13:10:04Z


we may simply load a dark palette for the main menubar since -right now- all our skins are rather dark.
See my latest comments in https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Getting.20rid.20of.20the.20menu.20bar/near/202829332

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2020-11-16T19:24:34Z


Closing this, dark mode is now supported thanks to the outstanding work @be put into the macOS build process. Thanks so much - it is highly appreciated.

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2020-11-16T19:25:05Z
Attachments: [mixxx dark mode macOS.png](https://bugs.launchpad.net/mixxx/+bug/1887280/+attachment/5434846/+files/mixxx dark mode macOS.png)

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-11-16T20:53:46Z


Nice.
Only the tree icons are kinda useless, except the Colors (brush) icon.
Maybe we should remove the gradients and make them all monochrome? That would only affect themes with a pure black background, with any other OS theme it would be fine IMO.

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2021-03-26T17:24:48Z


re-opening. due to issues which were introduced using newer versions of xcode this got reverted and is thus unfixed again.

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2021-09-20T08:04:15Z


And back to fix committed since #4225 was merged. Preferences and title bar are also respecting dark mode now.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Committed.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant