update yarn to 0.18.1 #2188
Merged
update yarn to 0.18.1 #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 81.84% (diff: 100%)@@ master #2188 diff @@
==========================================
Files 217 110 -107
Lines 11334 4136 -7198
Methods 973 0 -973
Messages 0 0
Branches 1552 438 -1114
==========================================
- Hits 9668 3385 -6283
+ Misses 1638 723 -915
Partials 28 28
|
| @@ -1,4 +1,4 @@ | |||
| FROM mitodl/mm_watch_travis_yarn | |||
| FROM mitodl/mm_watch_travis_yarn_update | |||
There was a problem hiding this comment.
What's the change here?
There was a problem hiding this comment.
I'm going to undo that - I was thinking we might want to point things at a different container, but I don't think we need to.
There was a problem hiding this comment.
s/container/image
alicewriteswrongs
changed the title
alicewriteswrongs
force-pushed
the
ap/yarn-update
branch
from
0a21bb4
to
831ae72
Compare
alicewriteswrongs
added a commit
that referenced
this pull request
Dec 21, 2016
Hopefully this will fix the 'module not found' error that was cropping up with node-sass. pr #2188
|
👍 Can you update the description to say that this is to fix a deploy problem on CI? |
|
yea |
Hopefully this will fix the 'module not found' error that was cropping up with node-sass, which was causing deploy failures on CI. pr #2188
alicewriteswrongs
force-pushed
the
ap/yarn-update
branch
from
831ae72
to
4fb2422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a deploy problem on CI, relevant yarn issues:
yarnpkg/yarn#2142
heroku/heroku-buildpack-nodejs#359
yarnpkg/yarn#1981