JamieMason#29 Don't flag constructors when this is not present

src/prefer-arrow-functions.spec.ts

@@ -56,6 +56,9 @@ const alwaysValid = [
   {
     code: 'class obj {constructor(foo){this.foo = foo;}}; obj.prototype = {func: function() {}};',
   },
+  {
+    code: 'class obj {constructor(private readonly foo: number){}};',
+  },
   {
     code: 'var foo = function() { return this.bar; };',
   },
@@ -126,6 +129,12 @@ const alwaysValid = [
   },
 ];
 
+const validWhenClassPropertiesAllowed = [
+  {
+    code: 'class obj {constructor(private readonly foo: number){}};',
+  },
+];
+
 const validWhenSingleReturnOnly = [
   {
     code: 'var foo = (bar) => {return bar();}',
@@ -835,7 +844,10 @@ const withErrors = (errors) => (object) => ({
 describe('when function is valid, or cannot be converted to an arrow function', () => {
   describe('it considers the function valid', () => {
     ruleTester.run('lib/rules/prefer-arrow-functions', rule, {
-      valid: alwaysValid,
+      valid: [
+        ...alwaysValid,
+        ...validWhenClassPropertiesAllowed.map(withOptions({ classPropertiesAllowed: true }))
+      ],
       invalid: [],
     });
   });

src/prefer-arrow-functions.ts

@@ -265,7 +265,7 @@ export default {
           });
         }
       },
-      ':matches(ClassProperty, MethodDefinition, Property)[key.name][value.type="FunctionExpression"][kind!=/^(get|set)$/]':
+      ':matches(ClassProperty, MethodDefinition, Property)[key.name][value.type="FunctionExpression"][kind!=/^(get|set|constructor)$/]':
         (node) => {
           const propName = node.key.name;
           const functionNode = node.value;