Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages/sw and packages/frontend are not typechecked in CI, and do not typecheck successfully. #10329

Open
yuchiki opened this issue Mar 15, 2023 · 6 comments
Labels
🛠️Dev Development of Misskey itself packages/frontend Client side specific issue/PR packages/sw

Comments

@yuchiki
Copy link

yuchiki commented Mar 15, 2023

💡 Summary

Misskey has three packages, namely backend, frontend and sw.
However, only backend package is typechecked in CI

(see also:

)

As a consequence, these modules' type information is obsoleted now so they don't typecheck. (I checked it with 'pnpm lint' command)

🥰 Expected Behavior

These two packages are correctly typed, and typechecked in CI.

🤬 Actual Behavior

N/A

📝 Steps to Reproduce

N/A

📌 Environment

N/A

I wrote a PR to fix types in sw, so I will publish it later.

@syuilo
Copy link
Member

syuilo commented Mar 15, 2023

Client-side type checking is intentionally disabled because it is impractical due to many type errors related to the DOM and other factors.

@saschanaz
Copy link
Member

saschanaz commented Mar 15, 2023

Client-side type checking is intentionally disabled because it is impractical due to many type errors related to the DOM and other factors.

I have to disagree as a maintainer of TypeScript DOM library, do you have a specific pain point? IMO errors are mainly coming from Vue use and misskey-js (#10322)

@acid-chicken
Copy link
Member

It's time to ditch vue Type checking is even worth the cost of using ts-ignore frequently.

@saschanaz
Copy link
Member

It's time to ditch vue

Custom Elements使いたいです

@yuchiki
Copy link
Author

yuchiki commented Mar 24, 2023

as a consequence of lacking typecheck in CI, some parts of type information written in the code are simply wrong, and it is not so desirable.

I have a desire to help the development of this project, and at least, for the first time, i would like to fix the wrong description of types.

@zyoshoka zyoshoka added 🛠️Dev Development of Misskey itself packages/frontend Client side specific issue/PR packages/sw and removed ⚠️bug? This might be a bug labels Jun 11, 2024
@zyoshoka
Copy link
Contributor

zyoshoka commented Jun 11, 2024

Related to (and blocked by) #10131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️Dev Development of Misskey itself packages/frontend Client side specific issue/PR packages/sw
Projects
Status: Triage
Development

Successfully merging a pull request may close this issue.

5 participants