-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packages/sw and packages/frontend are not typechecked in CI, and do not typecheck successfully. #10329
Comments
Client-side type checking is intentionally disabled because it is impractical due to many type errors related to the DOM and other factors. |
I have to disagree as a maintainer of TypeScript DOM library, do you have a specific pain point? IMO errors are mainly coming from Vue use and misskey-js (#10322) |
|
Custom Elements使いたいです |
as a consequence of lacking typecheck in CI, some parts of type information written in the code are simply wrong, and it is not so desirable. I have a desire to help the development of this project, and at least, for the first time, i would like to fix the wrong description of types. |
Related to (and blocked by) #10131 |
💡 Summary
Misskey has three packages, namely backend, frontend and sw.
However, only backend package is typechecked in CI
(see also:
misskey/.github/workflows/lint.yml
Line 63 in c05c504
As a consequence, these modules' type information is obsoleted now so they don't typecheck. (I checked it with 'pnpm lint' command)
🥰 Expected Behavior
These two packages are correctly typed, and typechecked in CI.
🤬 Actual Behavior
N/A
📝 Steps to Reproduce
N/A
📌 Environment
N/A
I wrote a PR to fix types in sw, so I will publish it later.
The text was updated successfully, but these errors were encountered: