-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed completion to work with modern zsh and git #281
Conversation
base_commands did not exist on my Ubuntu 12.10 with git 1.7.10.4 and zsh 5.0.0
Hey, thanks for looking at this. But does this also keep backwards compatibility for people for whom completion is working now? BTW see #231 where people are discussing better zsh completion ideas |
Probably not. Could probably be done with some regexp magic
|
Now it should be backwards compatible. |
Would the BASH one require an update as well? |
Perhaps. I have not looked into that. This completion script seems fairly
|
Nope, Bash seems to be fine. That autocompletion stuff did not have a namechange, at least not with my GNU bash, version 4.2.37(1)-release (x86_64-pc-linux-gnu) with git version 1.7.10.4 |
Anybody having Thanks |
OS, sed version?
|
salimane at salimane-desktop in ~
⚛ uname -a
Linux salimane-desktop 3.5.0-23-generic #35-Ubuntu SMP Thu Jan 24 13:15:40 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
salimane at salimane-desktop in ~
⚛ sed --version
GNU sed version 4.2.1
Copyright (C) 2009 Free Software Foundation, Inc.
salimane at salimane-desktop in ~
⚛ zsh --version
zsh 5.0.0 (x86_64-unknown-linux-gnu)
salimane at salimane-desktop in ~
⚛ git --version
git version 1.8.1.1
hub version 1.10.4
|
Interesting, I have the exact same version. I'll look into it later today On Wed, Jan 30, 2013 at 9:05 AM, Salimane Adjao Moustapha <
|
I can't reproduce @salimane's error: using his escaped version produces the error for me. |
@thomwiggers then it might be one my settings/configuration. I'll check it more. For now please ignore that error |
Closed in favor of #295, which I'm soon merging. @thomwiggers: Sorry to have ignored your contribution, but the PR that I'm referencing is a big overhaul of our zsh completion system and I've tested it to work well with latest git. |
base_commands did not exist on my Ubuntu 12.10 with git 1.7.10.4 and zsh 5.0.0