Changed completion to work with modern zsh and git

[thomwiggers]

base_commands did not exist on my Ubuntu 12.10 with git 1.7.10.4 and zsh 5.0.0

[mislav]

Hey, thanks for looking at this. But does this also keep backwards compatibility for people for whom completion is working now?

BTW see #231 where people are discussing better zsh completion ideas

[thomwiggers]

Probably not. Could probably be done with some regexp magic
Op 20 jan. 2013 21:15 schreef "Mislav Marohnić" notifications@github.com
het volgende:

Hey, thanks for looking at this. But does this also keep backwards
compatibility for people for whom completion is working now?

BTW see #231 #231 where people are
discussing better zsh completion ideas

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/281#issuecomment-12476616.

[thomwiggers]

Now it should be backwards compatible.

[ghost]

Would the BASH one require an update as well?

[thomwiggers]

Perhaps. I have not looked into that. This completion script seems fairly
specific to zsh.
Op 23 jan. 2013 23:13 schreef "Birger J. Nordølum" notifications@github.com
het volgende:

Would the BASH one require an update as well?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/281#issuecomment-12625637.

[thomwiggers]

Nope, Bash seems to be fine. That autocompletion stuff did not have a namechange, at least not with my GNU bash, version 4.2.37(1)-release (x86_64-pc-linux-gnu) with git version 1.7.10.4

[salimane]

Anybody having sed complaining on hub.zsh_completion with sed: -e expression #1, char 51: Unmatched ( or \( ?
the release version as well as this pr. Changing the regex part from eval "$(declare -f _git_commands | sed -e 's/main_porcelain_commands=(/main_porcelain_commands=(${_hub_commands} /')" to eval "$(declare -f _git_commands | sed -e 's/main_porcelain_commands=\(/main_porcelain_commands=(${_hub_commands} /')" solves the problem.

Thanks

[thomwiggers]

OS, sed version?
Op 30 jan. 2013 07:41 schreef "Salimane Adjao Moustapha" <
notifications@github.com> het volgende:

Anybody having sed complaining on hub.zsh_completion with sed: -e
expression #1, char 51: Unmatched ( or ( ?
the release version as well as this pr. Changing the regex part from eval
"$(declare -f _git_commands | sed -e
's/main_porcelain_commands=(/main_porcelain_commands=(${_hub_commands} /')"to eval
"$(declare -f _git_commands | sed -e
's/main_porcelain_commands=(/main_porcelain_commands=(${_hub_commands} /')"solves the problem.

Thanks

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/281#issuecomment-12876553.

[salimane]

salimane at salimane-desktop in ~
⚛ uname -a
Linux salimane-desktop 3.5.0-23-generic #35-Ubuntu SMP Thu Jan 24 13:15:40 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux

salimane at salimane-desktop in ~
⚛ sed --version
GNU sed version 4.2.1
Copyright (C) 2009 Free Software Foundation, Inc.

salimane at salimane-desktop in ~
⚛ zsh --version
zsh 5.0.0 (x86_64-unknown-linux-gnu)

salimane at salimane-desktop in ~
⚛ git --version
git version 1.8.1.1
hub version 1.10.4

[thomwiggers]

Interesting, I have the exact same version. I'll look into it later today
when I have some time available.

On Wed, Jan 30, 2013 at 9:05 AM, Salimane Adjao Moustapha <
notifications@github.com> wrote:

salimane at salimane-desktop in ~
⚛ uname -a
Linux salimane-desktop 3.5.0-23-generic #35-Ubuntu SMP Thu Jan 24 13:15:40 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux

salimane at salimane-desktop in ~
⚛ sed --version
GNU sed version 4.2.1
Copyright (C) 2009 Free Software Foundation, Inc.

salimane at salimane-desktop in ~
⚛ zsh --version
zsh 5.0.0 (x86_64-unknown-linux-gnu)

salimane at salimane-desktop in ~
⚛ git --version
git version 1.8.1.1
hub version 1.10.4

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/281#issuecomment-12878454.

[thomwiggers]

I can't reproduce @salimane's error: using his escaped version produces the error for me.

[salimane]

@thomwiggers then it might be one my settings/configuration. I'll check it more. For now please ignore that error

[mislav]

Closed in favor of #295, which I'm soon merging. @thomwiggers: Sorry to have ignored your contribution, but the PR that I'm referencing is a big overhaul of our zsh completion system and I've tested it to work well with latest git.