Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py is missing tensorflow dependency #221

Open
HitLuca opened this issue Jul 16, 2020 · 4 comments · May be fixed by #222
Open

setup.py is missing tensorflow dependency #221

HitLuca opened this issue Jul 16, 2020 · 4 comments · May be fixed by #222

Comments

@HitLuca
Copy link

HitLuca commented Jul 16, 2020

when installing this package, no tensorflow dependency is installed, because it's missing in the setup.py script. Given that it is a mandatory requirement, having it defined and locked to be a version prior to 2.0.0 would solve a bunch of issues
@jfrench206
Copy link

x2, would love a fix for this!!

@HitLuca HitLuca linked a pull request Jul 22, 2020 that will close this issue
Open
@HitLuca
Copy link
Author

HitLuca commented Jul 22, 2020

Here you are @jfrench206, we just need to wait for a merge now

@seanbow
Copy link

seanbow commented Jan 5, 2021

Afaik this usually isn't done because tensorflow<2 is split into two versions, tensorflow and tensorflow_gpu, and adding one as a requirement restricts users to one or the other.

@HitLuca
Copy link
Author

HitLuca commented Jan 5, 2021

I reckon that if the package by default uses tensorflow and the user then installs tensorflow_gpu on top of it, the project will use the gpu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added tensorflow (<2) dependency in setup.py HitLuca/gpt-2-simple
3 participants
@seanbow @HitLuca @jfrench206