Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I just ask why there is no Marketplace Support (Eg. What is stopping it) #627

Open
rahulc07 opened this issue Oct 26, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@rahulc07
Copy link

Is your feature request related to a problem? Please describe.
Yes, I do not really care about the marketplace, what I care about is the ability to change my skin. Since I am a bit of a dev as well I just want some info, why is the marketplace not working, my best guess is that it is authentication? Just a general summary of why its not working would be nice

Describe the solution you'd like
Just an explanation of why the Marketplace is not working, and how that is related to skins

Describe alternatives you've considered
There are not many that I can think of but maybe skin roaming? I think that requires the marketplace though. Or there might be a config file that you can edit to make it set a skin automatically, (Like when you select a custom skin (imported) on mobile it will stay there every time you launch the app). That might work.

@rahulc07 rahulc07 added the enhancement New feature or request label Oct 26, 2021
@ChristopherHX
Copy link
Member

I don't have the source code of the Minecraft Game and don't know how their marketplace is working.

why the Marketplace is not working

This launcher is barely maintained and fixing the marketplace takes a lot of my time, it stopped working in 1.16.210 or 1.16.220. The marketplace is a very fragile part of the game, it somehow magically worked in earlier versions. This launcher replaces all parts of the game which are written in java. Everytime the marketplace want to show prices of the play store, it calls stubbed methods, the buy coins button didn't load for a much longer time.

I have no more information to share, otherwise I would have fixed it.

how that is related to skins

  • Both marketplace and skin loading broke with the exact same Minecraft Version
  • In 1.18 the skin is overlayed by a marketplace loading error
  • In 1.17.30-40 you get an marketplace update prompt even if you are using the latest release
    • which is a recently introduced bug ( by mojang ) and make changing skins harder, but no impossible
      • change your skin while you are in a world
      • you see the update prompt too, but you can escape
      • press ESC until it closes
      • exit world
      • Now your skin changed in your session

there might be a config file that you can edit to make it set a skin automatically,

Your local skins are saved in your game config, but the game always wait for your marketplace.
AFAIK, marketplace skins you select via this launcher are synced to mobile devices, saving is not a problem.

Anyway you can contribute to this project, everything you need to fix the bug is in this project including submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants