-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Vietnamese entry in VOCAB #878
Conversation
Codecov Report
@@ Coverage Diff @@
## main #878 +/- ##
==========================================
- Coverage 94.84% 94.82% -0.02%
==========================================
Files 133 133
Lines 5200 5201 +1
==========================================
Hits 4932 4932
- Misses 268 269 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just a style check not passing, you need to split the line 34 which is too long in 2 :)
@charlesmindee Thanks for your comment, I have added the new commit of style fix. |
Hi @calibretaliation, if you want to use the librairy on Vietnamese OCR, you need to apply the you new vocab on a recognition model, you can keep the detection model as it is. However, you need to retrain the recognition model on you vocabulary with a labelled vietnamese dataset of word crops. For your PR, it would indeed be nice to indent so that flake8 is running without raising any error 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to align everything under the parenthesis, otherwise it is OK!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* feat: Added Vietnamese entry in VOCAB - update style fix 2 * feat: Added Vietnamese entry in VOCAB - update style fix 3
Missing PR labels here as well @charlesmindee :) Also, perhaps we should add specific contribution guidelines for vocab addition? I remember that for portuguese we had back & forth iterations, so perhaps we could ask to add a reference in the PR or better, as a comment in the code? |
@charlesmindee |
I added vietnamese VOCABS for Vietnamese devs if they want to use doctr for vietnamese like me :)