Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Drops support of np.float16 #627

Merged
merged 9 commits into from
Nov 16, 2021
Merged

refactor: Drops support of np.float16 #627

merged 9 commits into from
Nov 16, 2021

Conversation

fg-mindee
Copy link
Contributor

This PR introduces the following modifications:

  • removed fp16 support from datasets and models' preprocessors
  • removed support of np.float16 for targets in text detection models
  • adapted unittests

Any feedback is welcome!

@fg-mindee fg-mindee added module: models Related to doctr.models module: datasets Related to doctr.datasets labels Nov 15, 2021
@fg-mindee fg-mindee added this to the 0.4.1 milestone Nov 15, 2021
@fg-mindee fg-mindee self-assigned this Nov 15, 2021
@fg-mindee fg-mindee added the type: breaking change Introducing a breaking change label Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #627 (af1f665) into main (f8f6d3e) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
- Coverage   96.19%   96.09%   -0.10%     
==========================================
  Files         112      112              
  Lines        4335     4328       -7     
==========================================
- Hits         4170     4159      -11     
- Misses        165      169       +4     
Flag Coverage Δ
unittests 96.09% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/cord.py 97.43% <ø> (-0.07%) ⬇️
doctr/datasets/datasets/base.py 95.34% <100.00%> (-0.11%) ⬇️
doctr/datasets/datasets/pytorch.py 100.00% <100.00%> (ø)
doctr/datasets/datasets/tensorflow.py 100.00% <100.00%> (ø)
doctr/datasets/detection.py 96.87% <100.00%> (-0.10%) ⬇️
doctr/datasets/doc_artefacts.py 94.11% <100.00%> (ø)
doctr/datasets/iiit5k.py 96.77% <100.00%> (ø)
doctr/datasets/ocr.py 88.00% <100.00%> (ø)
doctr/datasets/recognition.py 76.00% <100.00%> (-16.00%) ⬇️
doctr/datasets/sroie.py 94.87% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f6d3e...af1f665. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fg-mindee fg-mindee merged commit fc22516 into main Nov 16, 2021
@fg-mindee fg-mindee deleted the fp16 branch November 16, 2021 11:27
@fg-mindee
Copy link
Contributor Author

cf #263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets module: models Related to doctr.models type: breaking change Introducing a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants