Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed some CI jobs with macOS #470

Merged
merged 1 commit into from
Sep 14, 2021
Merged

chore: Removed some CI jobs with macOS #470

merged 1 commit into from
Sep 14, 2021

Conversation

fg-mindee
Copy link
Contributor

Unfortunately, the CI is getting slower by the way and the suspect is mostly macOS jobs. This PR keeps macOS jobs to build the project and collect environment but removes the rest to speed up PR CI jobs.

Any feedback is welcome!

@fg-mindee fg-mindee added type: enhancement Improvement topic: ci Related to CI os: mac Involving Apple MAC users labels Sep 14, 2021
@fg-mindee fg-mindee added this to the 0.4.0 milestone Sep 14, 2021
@fg-mindee fg-mindee self-assigned this Sep 14, 2021
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #470 (4635285) into main (8660b4b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   95.80%   95.81%   +0.01%     
==========================================
  Files          95       95              
  Lines        4000     3992       -8     
==========================================
- Hits         3832     3825       -7     
+ Misses        168      167       -1     
Flag Coverage Δ
unittests 95.81% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/recognition/sar/pytorch.py 98.34% <0.00%> (-0.03%) ⬇️
doctr/models/recognition/crnn/pytorch.py 98.91% <0.00%> (-0.03%) ⬇️
doctr/models/recognition/sar/tensorflow.py 98.49% <0.00%> (-0.03%) ⬇️
doctr/models/recognition/zoo.py 100.00% <0.00%> (ø)
doctr/models/recognition/crnn/tensorflow.py 100.00% <0.00%> (ø)
doctr/models/core.py 94.61% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8660b4b...4635285. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cut!

@fg-mindee fg-mindee merged commit a735821 into main Sep 14, 2021
@fg-mindee fg-mindee deleted the macos-ci branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: mac Involving Apple MAC users topic: ci Related to CI type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants