-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecated clipping + removed 'None' metrics #432
Conversation
Codecov Report
@@ Coverage Diff @@
## main #432 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 96 96
Lines 3948 3948
=======================================
Hits 3784 3784
Misses 164 164
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Agree with the inplace clipping, but I added a comment for the metric
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edit, I just added a small suggestion for the log message 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR fixes:
Any feedback is welcome!