Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added a dual framework availability checker #306

Merged
merged 14 commits into from
Jun 11, 2021
Merged

Conversation

fg-mindee
Copy link
Contributor

@fg-mindee fg-mindee commented Jun 11, 2021

Following up on #261, this PR introduces the following modifications:

  • added a dynamic framework selection module (which can then be used to dynamically import the correct modules in __init__.py)
  • updated all installation instructions
  • updated installation commands
  • added a unittest

Any feedback is welcome!

@fg-mindee fg-mindee added critical High priority topic: build Related to dependencies and build labels Jun 11, 2021
@fg-mindee fg-mindee added this to the 0.3.0 milestone Jun 11, 2021
@fg-mindee fg-mindee self-assigned this Jun 11, 2021
@fg-mindee fg-mindee mentioned this pull request Jun 11, 2021
4 tasks
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #306 (7d01110) into main (f6b0ff9) will decrease coverage by 0.58%.
The diff coverage is 70.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   96.09%   95.50%   -0.59%     
==========================================
  Files          48       49       +1     
  Lines        2124     2181      +57     
==========================================
+ Hits         2041     2083      +42     
- Misses         83       98      +15     
Flag Coverage Δ
unittests 95.50% <70.21%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/file_utils.py 68.88% <68.88%> (ø)
doctr/__init__.py 100.00% <100.00%> (ø)
...tr/models/detection/differentiable_binarization.py 93.25% <0.00%> (-0.40%) ⬇️
doctr/datasets/ocr.py 91.89% <0.00%> (-0.22%) ⬇️
doctr/datasets/cord.py 97.50% <0.00%> (-0.07%) ⬇️
doctr/datasets/funsd.py 96.87% <0.00%> (ø)
doctr/datasets/sroie.py 94.73% <0.00%> (ø)
doctr/datasets/detection.py 97.14% <0.00%> (ø)
doctr/datasets/recognition.py 90.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b0ff9...7d01110. Read the comment docs.

Copy link
Collaborator

@charlesmindee charlesmindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charlesmindee charlesmindee merged commit 954531d into main Jun 11, 2021
@charlesmindee charlesmindee deleted the pytorch branch June 11, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical High priority topic: build Related to dependencies and build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants