Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ukrainian vocab #1700

Merged
merged 6 commits into from
Aug 21, 2024
Merged

feat: added ukrainian vocab #1700

merged 6 commits into from
Aug 21, 2024

Conversation

holyCowMp3
Copy link
Contributor

Added ukrainian vocab to allow use handwritten UA datasets

Added ukrainian vocab to allow use handwritten UA datasets
Added ukrainian language for possibility to use UA datasets and train OCR models
@felixdittrich92 felixdittrich92 self-assigned this Aug 21, 2024
@felixdittrich92 felixdittrich92 added this to the 0.9.1 milestone Aug 21, 2024
@felixdittrich92 felixdittrich92 added topic: documentation Improvements or additions to documentation type: enhancement Improvement module: datasets Related to doctr.datasets labels Aug 21, 2024
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @holyCowMp3 👋,
Thanks for the PR 👍

Could you please also add the entry in the documentation see as reference: #1687

doctr/datasets/vocabs.py Outdated Show resolved Hide resolved
doctr/datasets/vocabs.py Outdated Show resolved Hide resolved
@holyCowMp3
Copy link
Contributor Author

Hi @holyCowMp3 👋, Thanks for the PR 👍

Could you please also add the entry in the documentation see as reference: #1687

Done

@felixdittrich92
Copy link
Contributor

@holyCowMp3 entry in docs missing see: https://github.com/mindee/doctr/pull/1687/files
:)

@holyCowMp3
Copy link
Contributor Author

Знімок екрана 2024-08-21 о 18 17 39 Do we need to add the generic cyrrilic letters as well?

@felixdittrich92
Copy link
Contributor

Знімок екрана 2024-08-21 о 18 17 39 Do we need to add the generic cyrrilic letters as well?

Yes please :)

@holyCowMp3
Copy link
Contributor Author

Done

Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗

@felixdittrich92 felixdittrich92 merged commit 06bce51 into mindee:main Aug 21, 2024
79 checks passed
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (d7f4533) to head (17fbab2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
+ Coverage   96.38%   96.41%   +0.02%     
==========================================
  Files         164      164              
  Lines        7772     7773       +1     
==========================================
+ Hits         7491     7494       +3     
+ Misses        281      279       -2     
Flag Coverage Δ
unittests 96.41% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 modified the milestones: 0.9.1, 0.10.0 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants