Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datasets] Added Bangla characters to VOCABS #1676

Closed
wants to merge 1 commit into from
Closed

[datasets] Added Bangla characters to VOCABS #1676

wants to merge 1 commit into from

Conversation

bliss22
Copy link

@bliss22 bliss22 commented Jul 22, 2024 •
edited by felixdittrich92
Loading

This PR:

  • Add new vocab (bangla)
  • Add corresponding docs entry

@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone Jul 29, 2024
@felixdittrich92 felixdittrich92 self-assigned this Jul 29, 2024
@felixdittrich92 felixdittrich92 added topic: documentation Improvements or additions to documentation type: enhancement Improvement module: datasets Related to doctr.datasets ext: docs Related to docs folder labels Jul 29, 2024
felixdittrich92
felixdittrich92 requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bliss22 👋,

Thanks for the PR 👍

One small change and please add the new vocab also to the docs:

https://github.com/mindee/doctr/blob/main/docs/source/modules/datasets.rst

doctr/datasets/vocabs.py
@@ -66,6 +69,7 @@
+ VOCABS["danish"]
+ VOCABS["finnish"]
+ VOCABS["swedish"]
+ VOCABS["bangla"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this ftm, because we don't have bangla data atm we could use to train a multilingual model which includes this vocab 👍

@felixdittrich92 felixdittrich92 changed the title Added Bangla characters to VOCABS [datasets] Added Bangla characters to VOCABS Jul 29, 2024
@felixT2K felixT2K mentioned this pull request Aug 8, 2024
Merged
@felixdittrich92
Copy link
Contributor

Closed by #1687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixdittrich92 felixdittrich92 felixdittrich92 requested changes

Assignees

@felixdittrich92 felixdittrich92

Labels
ext: docs Related to docs folder module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation type: enhancement Improvement
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bliss22 @felixdittrich92