-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🔧 docker api use GitHub repository #1148
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
- Coverage 95.01% 94.99% -0.02%
==========================================
Files 150 150
Lines 6418 6418
==========================================
- Hits 6098 6097 -1
- Misses 320 321 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d992083
to
a8ea230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense :)
Thanks @odulcy-mindee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@odulcy-mindee job should be updated https://github.com/mindee/doctr/blob/main/.github/workflows/docker.yml seems make lock is missing |
3aab28d
@felixdittrich92 well, it's not needed anymore, I don't know why there is still these instructions, because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Fix #1126
Now, the docker container in
api
folder uses directly DocTR GitHub repository instead of the wheel on PyPI. This is done until0.7.0
is released.