Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🔧 docker api use GitHub repository #1148

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

odulcy-mindee
Copy link
Collaborator

Fix #1126

Now, the docker container in api folder uses directly DocTR GitHub repository instead of the wheel on PyPI. This is done until 0.7.0 is released.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #1148 (d992083) into main (3be90de) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d992083 differs from pull request most recent head 3aab28d. Consider uploading reports for the commit 3aab28d to get more accurate results

@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
- Coverage   95.01%   94.99%   -0.02%     
==========================================
  Files         150      150              
  Lines        6418     6418              
==========================================
- Hits         6098     6097       -1     
- Misses        320      321       +1     
Flag Coverage Δ
unittests 94.99% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/transforms/functional/base.py 95.65% <0.00%> (-1.45%) ⬇️
doctr/models/zoo.py 100.00% <0.00%> (ø)
doctr/datasets/svt.py 97.29% <0.00%> (ø)
doctr/datasets/cord.py 97.72% <0.00%> (ø)
doctr/datasets/ic03.py 97.43% <0.00%> (ø)
doctr/datasets/ic13.py 96.77% <0.00%> (ø)
doctr/datasets/svhn.py 95.34% <0.00%> (ø)
doctr/datasets/funsd.py 97.43% <0.00%> (ø)
doctr/datasets/sroie.py 97.36% <0.00%> (ø)
doctr/datasets/utils.py 93.97% <0.00%> (ø)
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense :)
Thanks @odulcy-mindee

aminemindee
aminemindee previously approved these changes Feb 15, 2023
Copy link
Contributor

@aminemindee aminemindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixdittrich92
Copy link
Contributor

felixdittrich92 commented Feb 15, 2023

@odulcy-mindee job should be updated https://github.com/mindee/doctr/blob/main/.github/workflows/docker.yml seems make lock is missing

@odulcy-mindee
Copy link
Collaborator Author

@odulcy-mindee job should be updated https://github.com/mindee/doctr/blob/main/.github/workflows/docker.yml seems make lock is missing

@felixdittrich92 well, it's not needed anymore, I don't know why there is still these instructions, because make lock occurs in the container now. We only need to execute pytest in the container now 👌

Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@felixdittrich92 felixdittrich92 added this to the 0.7.0 milestone Feb 15, 2023
@felixdittrich92 felixdittrich92 added type: bug Something isn't working topic: ci Related to CI topic: docker Docker-related ext: api Related to api folder labels Feb 15, 2023
@felixdittrich92 felixdittrich92 merged commit 9e254fe into main Feb 15, 2023
@felixdittrich92 felixdittrich92 deleted the api/use_doctr_repository branch February 15, 2023 14:48
@odulcy-mindee odulcy-mindee mentioned this pull request Feb 15, 2023
@felixdittrich92 felixdittrich92 modified the milestones: 0.8.0, 0.7.0 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: api Related to api folder topic: ci Related to CI topic: docker Docker-related type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API docker build
3 participants