Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Add in-memory cache for casbin enforcer result #35272

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #35271
See also #35270

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Aug 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 5, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 74.28571% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.13%. Comparing base (1b304e9) to head (c28c5d5).
Report is 6 commits behind head on 2.4.

Files Patch % Lines
internal/proxy/privilege_cache.go 70.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35272      +/-   ##
==========================================
- Coverage   81.19%   81.13%   -0.06%     
==========================================
  Files        1047     1053       +6     
  Lines      137322   137022     -300     
==========================================
- Hits       111496   111174     -322     
- Misses      21611    21629      +18     
- Partials     4215     4219       +4     
Files Coverage Δ
internal/proxy/meta_cache.go 93.37% <100.00%> (+<0.01%) ⬆️
internal/proxy/privilege_interceptor.go 76.57% <100.00%> (+0.87%) ⬆️
internal/proxy/privilege_cache.go 70.00% <70.00%> (ø)

... and 233 files with indirect coverage changes

See also milvus-io#35270

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@SimFG
Copy link
Contributor

SimFG commented Aug 6, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 2a1fc70 into milvus-io:2.4 Aug 6, 2024
13 of 15 checks passed
@yanliang567 yanliang567 added this to the 2.4.7 milestone Aug 6, 2024
@congqixia congqixia deleted the cp24/35271 branch August 7, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants