Use module#prepend when available. #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And when `super_method` is also available, as it is used in `render_with_wicked_pdf` when there is no `alias_method_chain`.
unixmonkey
commented
Mar 18, 2019
| @@ -5,20 +5,16 @@ | |||
| class WickedPdf | |||
| if defined?(Rails.env) | |||
|
|
|||
| if Rails::VERSION::MAJOR >= 5 | |||
| if Rails::VERSION::MAJOR >= 4 | |||
There was a problem hiding this comment.
The only difference between the Rails 4 and 5+ paths was :include vs prepend, so they were consolidated, and feature detection is now being used to determine whether to use :prepend or :include.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #810 It was discovered that version
1.2.0was released with an issue that would result in aSystemStackError (stack level too deep).I believe this has to do with the usage of
alias_method_chainapplied toActionController::Base#render, which may also be tampered with by something else in theGemfile.