Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect rails 5 assigns render option #801

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

dleavitt
Copy link
Contributor

@dleavitt dleavitt commented Mar 6, 2019

Rails 5 supports an assigns option to render/render_to_string that allows setting instance variables available to the template. This is particularly handy for rendering outside of controllers where these instance variables wouldn't otherwise be available.

It's a pass-through so I didn't add any new tests (but could.)

Rails 5 supports an `assigns` option to `render`/`render_to_string` that allows setting instance variables available to the template. This is particularly handy for rendering outside of controllers where these instance variables wouldn't otherwise be available.

It's a pass-through so I didn't add any new tests (but could.)
@unixmonkey unixmonkey merged commit d688444 into mileszs:master Mar 8, 2019
@unixmonkey
Copy link
Collaborator

Thank you very much. There are other options that probably need passed through (like :inline from #797), or perhaps we could take a reverse approach and only peel off options we need to mess with (as suggested in #633), but this does the job great. Thank you!

@dleavitt
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants