Use Rails logger instead of p #575

agombault · 2016-09-20T15:53:46Z

No description provided.

unixmonkey · 2016-09-20T21:06:20Z

lib/wicked_pdf.rb

@@ -105,7 +105,7 @@ def on_windows?
  end

  def print_command(cmd)
-    p '*' * 15 + cmd + '*' * 15
+    Rails.logger.debug '*' * 15 + cmd + '*' * 15 if defined?(Rails)


The if shouldn't be necessary since this is only called by in_development_mode?, which already does this check.

This is a good change, though!

agombault · 2016-09-21T07:56:48Z

@unixmonkey you're right for the if. I removed it.

unixmonkey · 2016-09-21T17:56:27Z

Thanks!

unixmonkey reviewed Sep 20, 2016

View reviewed changes

Use Rails logger instead of p

16b589b

agombault force-pushed the add_logger branch from 6c1853c to 16b589b Compare September 21, 2016 07:55

unixmonkey merged commit d6c4e9f into mileszs:master Sep 21, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Rails logger instead of p #575

Use Rails logger instead of p #575

agombault commented Sep 20, 2016

unixmonkey Sep 20, 2016

agombault commented Sep 21, 2016

unixmonkey commented Sep 21, 2016

Use Rails logger instead of p #575

Use Rails logger instead of p #575

Conversation

agombault commented Sep 20, 2016

unixmonkey Sep 20, 2016

Choose a reason for hiding this comment

agombault commented Sep 21, 2016

unixmonkey commented Sep 21, 2016