Add support for converting between Stochastic FP numbers, and convenience methods for array conversions #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2022 14:03
…venience functions for array conversions
milankl
reviewed
Aug 27, 2022
src/conversions.jl
Outdated
| Float16sr(x::Float32sr) = Float16sr(Float64(x)) | ||
|
|
||
| # Conversion of arrays as long as they are some kind of floating point number | ||
| function Float16sr(list::T where T<:AbstractArray{<:Union{BFloat16,AbstractFloat}}) |
There was a problem hiding this comment.
BFloat16 is already <:AbstractFloat?
julia> BFloat16<:AbstractFloat
true| @@ -1,3 +1,4 @@ | |||
| import BFloat16s.BFloat16 | |||
There was a problem hiding this comment.
instead of adding this to individual files, we can add import BFloat16s: BFloat16 to src/StochasticRounding.jl ?
| @@ -53,6 +54,10 @@ Base.Float64(x::Float32sr) = Float64(Float32(x)) | |||
| Float32sr(x::Integer) = Float32sr(Float32(x)) | |||
| (::Type{T})(x::Float32sr) where {T<:Integer} = T(Float32(x)) | |||
|
|
|||
| # converting to and from BFloat16 | |||
| Float32sr(x::BFloat16) = Float32sr(Float64(x)) | |||
There was a problem hiding this comment.
This should go via Float32 and not Float64? That will just padd trailing zeros and reinterpret
src/conversions.jl
Outdated
|
|
||
| # Conversions from other stochastic floating points to Float16sr | ||
| Float16sr(x::BFloat16sr) = Float16sr(Float32(x)) | ||
| Float16sr(x::Float32sr) = Float16sr(Float64(x)) |
There was a problem hiding this comment.
This should go via Float32 not Float64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to convert between Stochastic Floating Points just as we can for Deterministic types, and have convenience functions to convert entire arrays at a time
Add the above functionality without breaking any existing features, and test the implementation
Added extra functions that convert between the stochastic types with deterministic types as a middle step
Generated large amounts of random floating point numbers, ensured that these numbers were exactly representable in BFloat16, Float16, Float32, and Float64 via "daisy chaining" these conversions, and then testing that conversions were done properly