dns_query unit tests, require that field exists

miketonks · Mar 10, 2016 · 97a3261 · 97a3261
1 parent 7887b10
commit 97a3261
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/plugins/inputs/dns_query/dns_query_test.go b/plugins/inputs/dns_query/dns_query_test.go
@@ -1,11 +1,14 @@
 package dns_query
 
 import (
+	"testing"
+	"time"
+
 	"github.com/influxdata/telegraf/testutil"
+
 	"github.com/miekg/dns"
 	"github.com/stretchr/testify/assert"
-	"testing"
-	"time"
+	"github.com/stretchr/testify/require"
 )
 
 var servers = []string{"8.8.8.8"}
@@ -21,7 +24,7 @@ func TestGathering(t *testing.T) {
 	err := dnsConfig.Gather(&acc)
 	assert.NoError(t, err)
 	metric, ok := acc.Get("dns_query")
-	assert.True(t, ok)
+	require.True(t, ok)
 	queryTime, _ := metric.Fields["query_time_ms"].(float64)
 
 	assert.NotEqual(t, 0, queryTime)
@@ -38,7 +41,7 @@ func TestGatheringMxRecord(t *testing.T) {
 	err := dnsConfig.Gather(&acc)
 	assert.NoError(t, err)
 	metric, ok := acc.Get("dns_query")
-	assert.True(t, ok)
+	require.True(t, ok)
 	queryTime, _ := metric.Fields["query_time_ms"].(float64)
 
 	assert.NotEqual(t, 0, queryTime)
@@ -61,7 +64,7 @@ func TestGatheringRootDomain(t *testing.T) {
 	err := dnsConfig.Gather(&acc)
 	assert.NoError(t, err)
 	metric, ok := acc.Get("dns_query")
-	assert.True(t, ok)
+	require.True(t, ok)
 	queryTime, _ := metric.Fields["query_time_ms"].(float64)
 
 	fields["query_time_ms"] = queryTime
@@ -84,7 +87,7 @@ func TestMetricContainsServerAndDomainAndRecordTypeTags(t *testing.T) {
 	err := dnsConfig.Gather(&acc)
 	assert.NoError(t, err)
 	metric, ok := acc.Get("dns_query")
-	assert.True(t, ok)
+	require.True(t, ok)
 	queryTime, _ := metric.Fields["query_time_ms"].(float64)
 
 	fields["query_time_ms"] = queryTime