add draft ros-security feedback #1
Open
Commits on Mar 10, 2020
-
add draft ros-security feedback
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Commits on Mar 16, 2020
-
Apply suggestions from code review
Co-Authored-By: Víctor Mayoral Vilches <v.mayoralv@gmail.com> Co-Authored-By: SidFaber <56845980+SidFaber@users.noreply.github.com>
3 people authoredMar 16, 2020
Commits on Mar 20, 2020
-
rearrange feedback document, all actionable questions at the top and …
…quality + security below as discussion points Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Commits on Mar 24, 2020
-
merge 2 responsiveness items together
Co-Authored-By: Kyle Fazzari <github@status.e4ward.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.