Import Markup from markupsafe (future deprecation) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed this while testing the current flask2 rc suite. Note there's a bug in the current rc preventing `jinja2.Markup` from working. A fix has been committed already. Instead, `Markup` should be imported from `markupsafe`. I checked and this has been possible for many years now (jinja 2.9.x branch from 2y ago imports from here already). Note jinja 3.0.0 will emit a deprecation warning, with removal in 3.1, so a whiles away for sure. Nonetheless, it should be a backwards-compatible change, so there shouldn't be any issue changing it now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while testing the current flask2 rc suite. Note there's a bug in the current rc preventing
jinja2.Markupfrom working. A fix has been committed already.Instead,
Markupshould be imported frommarkupsafe. I checked and this has been possible for many years now (jinja 2.9.x branch from 2y ago imports from here already).Note jinja 3.0.0 will emit a deprecation warning, with removal in 3.1, so a whiles away for sure. Nonetheless, it should be a backwards-compatible change, so there shouldn't be any issue changing it now.