Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substract and add integration #35

Closed
fl0wx opened this issue Jan 5, 2018 · 6 comments
Closed

Substract and add integration #35

fl0wx opened this issue Jan 5, 2018 · 6 comments
Assignees

Comments

@fl0wx
Copy link

fl0wx commented Jan 5, 2018

Hey is it possible to add the support for using moment().substraction(7, 'days') and add? Like in the official module?

Thanks a lot and kr
flow

@ghost
Copy link

ghost commented Aug 16, 2018

Seconded. Being able to access functions such as .add(), .subtract() and .diff() would be great.

@miguelgrinberg miguelgrinberg self-assigned this Aug 16, 2018
@br0cky
Copy link

br0cky commented Dec 7, 2018

Another vote for this! Diff would be great as i was hoping to be able to compare dates e.g if date is older than x days...

@antmurph
Copy link

any update on this issue? Would be a great feature to have

@miguelgrinberg
Copy link
Owner

@antmurph if you'd like to have a go at it I'm happy to help. Eventually I'll get to it, but right now I don't have time unfortunately.

@antmurph
Copy link

@miguelgrinberg take a look at the PR, for my uses that works perfect.

@miguelgrinberg
Copy link
Owner

After some discussion in this and other issues I have decided I will not be adding add and substract, since this just perform calculations with dates and not formatting. If you need to add or substract dates, you can do it directly in Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants