Now uses grammar endpoint on api.greynir.is. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es not display progress
| from datetime import datetime | ||
| from typing import TYPE_CHECKING, Any, Dict, List, Optional, Pattern, Tuple, Union, cast |
There was a problem hiding this comment.
Hmm, it is canonical to have imports from typing first in the import sequence...
|
|
||
| app.register_blueprint(routes_blueprint) | ||
|
|
||
| from routes import start_task_cleanup_thread |
There was a problem hiding this comment.
Hmm, where did these go? It's not possible to delete them completely?
| dirs: List[str] = list( | ||
| map(os.path.dirname, [__file__, reynir.__file__, reynir_correct.__file__]) # type: ignore | ||
| ) | ||
| dirs: List[str] = list(map(os.path.dirname, [__file__, reynir.__file__])) # type: ignore |
There was a problem hiding this comment.
I think type:ignore might no longer be needed - it's probably there because of an early bug in Pylance.
| @@ -350,7 +313,4 @@ def resource_gone(e: BaseException) -> Tuple[Response, int]: | |||
| ) | |||
| app.logger.info(log_str) # type: ignore | |||
|
|
|||
| # Pre-load the correction engine into memory | |||
There was a problem hiding this comment.
This was there to make the first request response time a bit lower, while taking a tiny bit more time to initialize the server.
|
|
||
| from correct import check_grammar, validate_token_and_nonce | ||
| from doc import SUPPORTED_DOC_MIMETYPES, doc_class_for_mime_type | ||
| from typing_extensions import Literal |
There was a problem hiding this comment.
This might be importable from typing now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still synchronous and does not display progress. At the moment GreynirSeqAPI doesn't return the "details" for a given error so it is not displayed on the interface.
Things that are still left to do before merging: